github new version
|
You really need to use a code formatting tool just looking at that gave me cancer.
|
Quote:
|
Minifying php code has no significant performance improvements it's negligible at best.
https://stackoverflow.com/questions/...ng-php/4079952 |
Quote:
|
your well written and fast code is still using mysql instead of mysqli or pdo .. enough said
but who likes it, likes it and will use it..despite the serious downfall |
Quote:
I'll give you an example of how Yuna's script works. Bluebird and teamhd work on older versions, with mysql. Bluebird is generally in Cyrillic and do not want to switch to utf8, you can compare the speed of these sites and our test. In addition, in defense of mysql, if the script is configured correctly on nginx, then pdo is not needed. https://teamhd.org https://bluebird-hd.org https://hdclub.top |
@Elena
It's your code and you can write it any way you like. I am not posting to criticize your choice. I would just like to provide a little information. You can take it or leave it. Minification and compression are great for artifacts(css, js, html) that the browser downloads. The browser does not download php code. The server has to open the file, read it and compile into opcode. Since you are not compressing the file, only removing whitespace, there is no performance loss to decompress it. When php reads a file, all comments and white space are entirely ignored by the interpreter, so there is no benefit whatsoever to removing all of the whitespace. The only thing you are adding to it by doing so is making it nearly impossible for anyone else to read your code. I have forked your repo, added php-cs-fixer and it fails on 12 files. If you would like, I can edit your code so that it is more easily readable and update for php 7.3 which if you're doing all this for speed, is the greatest speed improvement you can do. I may do this anyway and post it to my fork. Here is a link to a phoronix benchmark showing in all cases a 200%-500% increase in performance and reduction in processing time. This is just my 2 cents and you don't have to agree or even listen, but I appreciate you taking the time to read it. |
Quote:
server: FastCGI (Nginx + PHP-FPM) PHP 5.4.16 is equivalent in speed to PHP7 in the same bundle. Do the tests themselves. Now our test site is working on such a link, you can check the speed yourself. :coffee: |
I don't think anything we say is going to get through to you.
|
All times are GMT +2. The time now is 17:14. |
Powered by vBulletin® Version 3.8.11 Beta 3
Copyright ©2000 - 2024, vBulletin Solutions Inc.